On 10/7/2019 10:01 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > Hi Ferruh, > >> Hi Jakub, >> >> While testing your zero-copy patch [1], I stuck to a bind() error [2]. >> When provided a socket length bigger than "sizeof(struct sockaddr)", bind() >> fails. I am testing this on a Fedora system. >> I wonder if there is a check in glibc related to the length. > > Zero-copy patch does not contain this fix, in fact, I can't find this > patch in the commit log. > It was supposed to be applied on 2019-09-13. > http://git.dpdk.org/next/dpdk-next-net/log/?ofs=400 > Was there any problem with apply? Maybe because the patch is RFC?
No zero-copy patch doesn't contain it. It is already in the repo. I hit the issue while testing zero-copy, other than that there is no relation to zero-copy feature J The commit is in next-net tree, it is not released yet: f018cfa797eb ("net/memif: allow for full key size in socket name") Briefly, I am having issues with that commit, bind() fails, but it has your Tested-by tag. Can you please confirm it again? > >> >> What was your test platform for the change? > > Ubuntu 18.04 So you are on Linux as well, I wonder what is the difference. > >> >> >> >> [1] >> https://patches.dpdk.org/patch/57817/ >> >> [2] >> memif_socket_create(): NULL: Failed to setup socket /run/memif.sock: Invalid >> argument