On 12/25/2015 1:40 AM, Pattan, Reshma wrote: > >> -----Original Message----- >> From: Qiu, Michael >> On 12/23/2015 8:19 PM, Reshma Pattan wrote: >>> Macros RTE_PROC_PRIMARY_OR_ERR_RET and >> RTE_PROC_PRIMARY_OR_RET are >>> blocking the secondary process from using the APIs. >>> API access should be given to both secondary and primary. >> Just as the log says, is it safe to do so? > > Hi, > > Some parts of the code still need these macros, which I am not sure yet. But > as and when we identify those we have to add the macros to the needed places. > But it is safe to remove from start of function to allow secondary process to > do device configuration and queue setups for vdev. > Please let me know if you know any of such cases where these macros should be > added.
You you have removed almost all secondary check, and as I know, with your patch, secondary almost has full control of a device, what's the exact demand for secondary to have full API access? It's a big change for DPDK I think, but patch set itself is good for me:) Thanks, Michael > Thanks, > Reshma > >
