Hi Abdul,
Comments inline.
On 27/08/2019 17:44, Abdul Halim wrote:
> Adding a Dockerfile with Ubuntu bionic base image to build dpdk
> as shared library. This docker image could be used as base image to
> build and run dpdk applications in containers.
>
> Signed-off-by: Abdul Halim <abdul.ha...@intel.com>
> ---
> extras/Dockerfile.ubuntu | 38 ++++++++++++++++++++++++++++++++++++++
> extras/README.md | 8 ++++++++
> 2 files changed, 46 insertions(+)
> create mode 100644 extras/Dockerfile.ubuntu
> create mode 100644 extras/README.md
>
> diff --git a/extras/Dockerfile.ubuntu b/extras/Dockerfile.ubuntu
So I would be concerned about it being called Dockerfile.ubuntu, because
at the moment it only covers Bionic, and Xenial is still supported until
April 21. The pattern FD.io VPP adopts is calling it Dockerfile.bionic.
> new file mode 100644
> index 0000000..3d5b36b
> --- /dev/null
> +++ b/extras/Dockerfile.ubuntu
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019 Intel Corporation
> +FROM ubuntu:bionic
> +
> +# install requirements for getting and building DPDK
> +# including dependencies for DPDK features
> +RUN apt-get update && apt-get install -y \
> + build-essential \
> + pkgconf \
> + python3 \
> + python3-pip \
> + ninja-build \
> + libjansson-dev \
> + libbsd-dev \
> + libnuma-dev \
> + libssl-dev \
> + zlib1g-dev \
> + libpcap-dev \
> + libibverbs-dev \
> + && pip3 install meson
> +
> +ADD . /tmp/dpdk
> +
> +WORKDIR /tmp/dpdk
> +
> +RUN meson build \
> + -Ddefault_library=shared \
> + -Dmachine=default \
> + -Dper_library_versions=false \
> + && ninja -C build install \
> + && cd /; rm -rf /tmp/dpdk
> +
Is it safe to remove /tmp/dpdk, then remove the WORKDIR.
Should be the other way around?
> +WORKDIR /
> +
> +# Installed DPDK Shared library location:
> +# lib dir : /usr/local/lib/
> +# include : /usr/local/include/
> +# pkgconfig file: /usr/local/lib/x86_64-linux-gnu/pkgconfig/libdpdk.pc
> diff --git a/extras/README.md b/extras/README.md
> new file mode 100644
> index 0000000..967ddf7
> --- /dev/null
> +++ b/extras/README.md
> @@ -0,0 +1,8 @@
> +# Build DPDK Docker image
> +
> +To build a docker image run the following command from dpdk root directory.
> +
> +```
> +DOCKER_TAG="dpdk"
> +docker build -t ${DOCKER_TAG} -f extras/Dockerfile.ubuntu .
> +```
>
