Hi Hemant, It is actually me who missed the .rst file. Thanks for pointing out. I have fixed that in v2 as well as the copyrights ownership of `meson.build` remained unchanged.
Best regards, Maciej On Fri, Sep 27, 2019 at 10:49 AM Hemant Agrawal <hemant.agra...@nxp.com> wrote: > Hi Michal, > You also missed doc/guides/nics/ena.rst > > Regards, > Hemant > > > -----Original Message----- > > From: Michał Krawczyk <m...@semihalf.com> > > Sent: Friday, September 27, 2019 1:46 PM > > To: Hemant Agrawal <hemant.agra...@nxp.com> > > Cc: Ferruh Yigit <ferruh.yi...@intel.com>; Maciej Bielski > > <m...@semihalf.com>; dev@dpdk.org; Marcin Wojtas > > <m...@semihalf.com>; Guy Tzalik <gtza...@amazon.com>; Evgeny Schemeilin > > <evge...@amazon.com>; Chauskin, Igor <igo...@amazon.com> > > Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to SPDX > tags > > Importance: High > > > > + Igor > > > > pt., 27 wrz 2019 o 07:32 Hemant Agrawal <hemant.agra...@nxp.com> > > napisał(a): > > > > > > > > > > -----Original Message----- > > > > From: dev <dev-boun...@dpdk.org> On Behalf Of Ferruh Yigit > > > > Sent: Thursday, September 26, 2019 11:17 PM > > > > To: Maciej Bielski <m...@semihalf.com>; dev@dpdk.org > > > > Cc: Marcin Wojtas <m...@semihalf.com>; Michal Krawczyk > > > > <m...@semihalf.com>; Guy Tzalik <gtza...@amazon.com>; Evgeny > > > > Schemeilin <evge...@amazon.com> > > > > Subject: Re: [dpdk-dev] [PATCH] net/ena: change license clause to > > > > SPDX tags > > > > > > > > On 9/26/2019 1:31 PM, Maciej Bielski wrote: > > > > > Signed-off-by: Maciej Bielski <m...@semihalf.com> > > > > > Acked-by: Michal Krawczyk <m...@semihalf.com> > > > > > > > > <...> > > > > > > > > > diff --git a/drivers/net/ena/meson.build > > > > > b/drivers/net/ena/meson.build index 091ca6e3f..c7e71f494 100644 > > > > > --- a/drivers/net/ena/meson.build > > > > > +++ b/drivers/net/ena/meson.build > > > > > @@ -1,5 +1,6 @@ > > > > > # SPDX-License-Identifier: BSD-3-Clause -# Copyright(c) 2018 > > > > > Intel Corporation > > > > > +# Copyright(c) 2015-2019 Amazon.com, Inc. or its affiliates. > > > > > +# All rights reserved. > > > > > > > > > > > > > This part is changing the copyright owner, it is under the ena > > > > driver but still is there a reason to change the owner? > > > > > > > > Overall this is a meson file, I personally don't see the meaning of > > > > having a copyright in a meson file, but trying to be fair. > > > > > > > > Would you mind keeping the original copyright for the file? > > > [Hemant] Not sure, if you kept the Intel's copyright by mistake or you > > copied this file from other driver having Intel's copyright. > > > You may like to keep add yours, but not delete the old one. > > > > Ok, let's keep the Intel's copyright. > > > > Thanks, > > Michal >
