On 9/27/2019 7:52 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit > > I sent out PATCH V3 to fix the conflict that occurs in > doc/guides/rel_notes/release_19_11.rst when performing > 'git am patch(PATCH V2 series)' operation based on the latest > dpdk-next-net because of the recent change in the repository. > > The page in patches.dpdk.org indicates that CI checking > against this series failed and terminated, the content of 'S/W/F' field is > '---', the page as follows: > http://patches.dpdk.org/project/dpdk/list/?series=&submitter=1405&state=*&q=&archive=&delegate= > > The information of CI building as follows, and in fact > there was non incompatible pointer type error based on > the latest repo in my local server. > http://mails.dpdk.org/archives/test-report/2019-September/099170.html > > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .promiscuous_enable = hns3_dev_promiscuous_enable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4723:24: > note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_enable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .promiscuous_disable = hns3_dev_promiscuous_disable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4724:25: > note: (near initialization for ‘hns3_eth_dev_ops.promiscuous_disable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .allmulticast_enable = hns3_dev_allmulticast_enable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4725:26: > note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_enable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .allmulticast_disable = hns3_dev_allmulticast_disable, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4726:26: > note: (near initialization for ‘hns3_eth_dev_ops.allmulticast_disable’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .stats_reset = hns3_stats_reset, > ^~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4729:24: > note: (near initialization for ‘hns3_eth_dev_ops.stats_reset’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .xstats_reset = hns3_dev_xstats_reset, > ^~~~~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4732:24: > note: (near initialization for ‘hns3_eth_dev_ops.xstats_reset’) > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: > error: initialization from incompatible pointer type > [-Werror=incompatible-pointer-types] > .dev_infos_get = hns3_dev_infos_get, > ^~~~~~~~~~~~~~~~~~ > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/drivers/net/hns3/hns3_ethdev.c:4735:28: > note: (near initialization for ‘hns3_eth_dev_ops.dev_infos_get’) > cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ > [-Werror] > cc1: all warnings being treated as errors > /home-local/jenkins-local/jenkins-agent/workspace/Apply-Custom-Patch-Set/dpdk/mk/internal/rte.compile-pre.mk:114: > recipe for target 'hns3_ethdev.o' failed > make[6]: *** [hns3_ethdev.o] Error 1 > > > The detail information of the repository when making PATCH V3 on as > follows: > > repo: http://dpdk.org/git/next/dpdk-next-net > branch: master
Hi Xavier, Above repo and the branch is correct, also with a quick check your code seems correct too. CI is using wrong tree for the build test [1], @Ali, @Aaron and @Jeremy are on cc for long term investigation. Hopefully there will be a merge from next-net to main repo, that should fix the false positives in CI. Can you please follow the merge and ping us, so we can ask to Jeremy to re-run the test? Thanks, ferruh [1] Metadata from test: " Test-Label: Performance-Testing Test-Status: FAILURE http://dpdk.org/patch/59882 _build patch failure_ Submitter: Wei Hu (Xavier) <xavier.huwei at huawei.com> Date: Thursday, September 26 2019 14:01:47 Applied on: CommitID:bd253daa7717835f88bbc58b09a94d0060380396 Apply patch set 59882-59901 failed: " Commit is from the main tree, that is why causing the build error. > > git log --oneline > 3be6962 app/testpmd: fix unused variable compile error > 5453153 app/testpmd: fix crash on port reset > 944ee10 net/ipn3ke: setup MTU during HW init > 52e3ab3 net/ice: remove Rx legacy descriptor definition > d27982e net/ice: switch to Rx flexible descriptor in AVX path > 0973c28 net/ice: switch to flexible descriptor in SSE path > 98ed8c1 net/ice: add protocol extraction support for per Rx queue > 03ff0d1 net/ice: handle the Rx flex descriptor > 2962f75 net/ice: add Rx flex descriptor definition > a03e11f net/i40e: limit the number of VF messages > 644032b net/ice/base: remove unused code > c02031f net/ice/base: add switch support for IPv6 tc field > 05859a5 net/ice/base: fix PTYPE bitmap > 4f07dc0 net/ice/base: fix alignment > 9d1c626 net/ice/base: use bitmap copy where appropriate > 3efd0a4 net/ice/base: remove unnecessary error log > 82c1c29 net/ice/base: fix 4 bytes alignment for PPPoE dummy packet > 17db50c net/ice/base: search field vector indices for result slots > 9ef53fb net/ice/base: remove unused DDP package macros > 665293f net/ice/base: fix segment in remove existing RSS rule > 079ca8c net/ice/base: fix the bitmap for TCP in RSS > d3e1ebd net/ice/base: add FDIR support for GTPU QFI field > > > Is there a way to reconstruct PATCH V3 in CI? Do we > resend PATCH V3 to trigger CI reconstruct them again? > Thanks for your suggestion. > > Regards > Xavier > > > On 2019/9/26 22:01, Wei Hu (Xavier) wrote: >> The Hisilicon Network Subsystem is a long term evolution IP which is >> supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. >> >> This series add DPDK rte_ethdev poll mode driver for Hisilicon >> Network Subsystem 3(hns3) network engine. >> >> v2 -> v3: >> 1. Resolve the conflict problem when performing git operation >> based on the current repository. The conflict occurs in >> doc/guides/rel_notes/release_19_11.rst. >> >> v1 -> v2: >> 1. Address some comments from Jerin Jacob Kollanukkaran, >> Stephen Hemminger and Ferruh Yigit. >> >> Wei Hu (Xavier) (22): >> net/hns3: add build and doc infrastructure >> net/hns3: add hardware registers definition >> net/hns3: add some definitions for data structure and macro >> net/hns3: register hns3 PMD driver and add the log interface >> definition >> net/hns3: add support for cmd of hns3 PMD driver >> net/hns3: add the initialization of hns3 PMD driver >> net/hns3: add support for MAC address related operations >> net/hns3: add support for some misc operations >> net/hns3: add support for link_update operation >> net/hns3: add support for flow directory of hns3 PMD driver >> net/hns3: add support for RSS of hns3 PMD driver >> net/hns3: add support for flow control of hns3 PMD driver >> net/hns3: add support for vlan of hns3 PMD driver >> net/hns3: add support for mailbox of hns3 PMD driver >> net/hns3: add support for hns3 VF PMD driver >> net/hns3: add RX/TX package burst and queue related operation >> net/hns3: add start stop configure promiscuous ops >> net/hns3: add dump register ops for hns3 PMD driver >> net/hns3: add abnormal interrupt process for hns3 PMD driver >> net/hns3: add stats related ops for hns3 PMD driver >> net/hns3: add reset related process for hns3 PMD driver >> net/hns3: add multiple process support for hns3 PMD driver >> >> MAINTAINERS | 8 + >> config/common_base | 5 + >> config/common_linux | 5 + >> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + >> config/defconfig_i686-native-linuxapp-gcc | 5 + >> config/defconfig_i686-native-linuxapp-icc | 5 + >> config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + >> config/defconfig_x86_64-native-linuxapp-icc | 5 + >> config/defconfig_x86_x32-native-linuxapp-gcc | 5 + >> doc/guides/nics/features/hns3.ini | 34 + >> doc/guides/nics/features/hns3_vf.ini | 29 + >> doc/guides/nics/hns3.rst | 60 + >> doc/guides/nics/index.rst | 1 + >> doc/guides/rel_notes/release_19_11.rst | 6 + >> drivers/net/Makefile | 1 + >> drivers/net/hns3/Makefile | 45 + >> drivers/net/hns3/hns3_cmd.c | 565 +++ >> drivers/net/hns3/hns3_cmd.h | 761 ++++ >> drivers/net/hns3/hns3_dcb.c | 1642 +++++++++ >> drivers/net/hns3/hns3_dcb.h | 166 + >> drivers/net/hns3/hns3_ethdev.c | 4947 >> ++++++++++++++++++++++++++ >> drivers/net/hns3/hns3_ethdev.h | 645 ++++ >> drivers/net/hns3/hns3_ethdev_vf.c | 1725 +++++++++ >> drivers/net/hns3/hns3_fdir.c | 1059 ++++++ >> drivers/net/hns3/hns3_fdir.h | 205 ++ >> drivers/net/hns3/hns3_flow.c | 1903 ++++++++++ >> drivers/net/hns3/hns3_intr.c | 1166 ++++++ >> drivers/net/hns3/hns3_intr.h | 79 + >> drivers/net/hns3/hns3_logs.h | 34 + >> drivers/net/hns3/hns3_mbx.c | 353 ++ >> drivers/net/hns3/hns3_mbx.h | 136 + >> drivers/net/hns3/hns3_mp.c | 214 ++ >> drivers/net/hns3/hns3_mp.h | 14 + >> drivers/net/hns3/hns3_regs.c | 368 ++ >> drivers/net/hns3/hns3_regs.h | 99 + >> drivers/net/hns3/hns3_rss.c | 584 +++ >> drivers/net/hns3/hns3_rss.h | 124 + >> drivers/net/hns3/hns3_rxtx.c | 1676 +++++++++ >> drivers/net/hns3/hns3_rxtx.h | 317 ++ >> drivers/net/hns3/hns3_stats.c | 975 +++++ >> drivers/net/hns3/hns3_stats.h | 152 + >> drivers/net/hns3/meson.build | 37 + >> drivers/net/hns3/rte_pmd_hns3_version.map | 3 + >> drivers/net/meson.build | 1 + >> mk/rte.app.mk | 1 + >> 45 files changed, 20167 insertions(+) >> create mode 100644 doc/guides/nics/features/hns3.ini >> create mode 100644 doc/guides/nics/features/hns3_vf.ini >> create mode 100644 doc/guides/nics/hns3.rst >> create mode 100644 drivers/net/hns3/Makefile >> create mode 100644 drivers/net/hns3/hns3_cmd.c >> create mode 100644 drivers/net/hns3/hns3_cmd.h >> create mode 100644 drivers/net/hns3/hns3_dcb.c >> create mode 100644 drivers/net/hns3/hns3_dcb.h >> create mode 100644 drivers/net/hns3/hns3_ethdev.c >> create mode 100644 drivers/net/hns3/hns3_ethdev.h >> create mode 100644 drivers/net/hns3/hns3_ethdev_vf.c >> create mode 100644 drivers/net/hns3/hns3_fdir.c >> create mode 100644 drivers/net/hns3/hns3_fdir.h >> create mode 100644 drivers/net/hns3/hns3_flow.c >> create mode 100644 drivers/net/hns3/hns3_intr.c >> create mode 100644 drivers/net/hns3/hns3_intr.h >> create mode 100644 drivers/net/hns3/hns3_logs.h >> create mode 100644 drivers/net/hns3/hns3_mbx.c >> create mode 100644 drivers/net/hns3/hns3_mbx.h >> create mode 100644 drivers/net/hns3/hns3_mp.c >> create mode 100644 drivers/net/hns3/hns3_mp.h >> create mode 100644 drivers/net/hns3/hns3_regs.c >> create mode 100644 drivers/net/hns3/hns3_regs.h >> create mode 100644 drivers/net/hns3/hns3_rss.c >> create mode 100644 drivers/net/hns3/hns3_rss.h >> create mode 100644 drivers/net/hns3/hns3_rxtx.c >> create mode 100644 drivers/net/hns3/hns3_rxtx.h >> create mode 100644 drivers/net/hns3/hns3_stats.c >> create mode 100644 drivers/net/hns3/hns3_stats.h >> create mode 100644 drivers/net/hns3/meson.build >> create mode 100644 drivers/net/hns3/rte_pmd_hns3_version.map >> > >
