> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Thursday, September 26, 2019 1:37 AM > > On Wed, 25 Sep 2019 14:17:42 +0200 > Morten Brørup <m...@smartsharesystems.com> wrote: > > > Dear Thomas - listed as checkpatch maintainer, > > > > I think this warning is bogus, and is a bug checkpatch. > > > > The line in question was deliberately indented using tabs to the > current indentation level, and using spaces for the readability > alignment. This makes the code readable in editors with another tab > setting than 8 spaces. E.g. 4 spaces is my personal preference. > > > > > > Med venlig hilsen / kind regards > > - Morten Brørup > > It is understandable that you have personal preferences, but projects > like DPDK rely > on common style across all code. The collective decision has been made > to keep a > uniform style similar to the Linux kernel. > > No it is not a bug in checkpatch.
Thank you for the prompt feedback, Stephen. I thought I could get the best of both worlds with this method of indentation. But since it's against the style guide, I'll change it to comply. Med venlig hilsen / kind regards - Morten Brørup
