On 9/25/2019 3:30 PM, Xiaoyun wang wrote: > This patch supports setting link down and up, > Also adds support for geting firmware version. > > Signed-off-by: Xiaoyun wang <cloud.wangxiao...@huawei.com>
<...> > @@ -2751,9 +2832,12 @@ static void hinic_dev_close(struct rte_eth_dev *dev) > static const struct eth_dev_ops hinic_pmd_ops = { > .dev_configure = hinic_dev_configure, > .dev_infos_get = hinic_dev_infos_get, > + .fw_version_get = hinic_fw_version_get, > .rx_queue_setup = hinic_rx_queue_setup, > .tx_queue_setup = hinic_tx_queue_setup, > .dev_start = hinic_dev_start, > + .dev_set_link_up = hinic_dev_set_link_up, > + .dev_set_link_down = hinic_dev_set_link_down, > .link_update = hinic_link_update, > .rx_queue_release = hinic_rx_queue_release, > .tx_queue_release = hinic_tx_queue_release, > @@ -2785,6 +2869,7 @@ static void hinic_dev_close(struct rte_eth_dev *dev) > static const struct eth_dev_ops hinic_pmd_vf_ops = { > .dev_configure = hinic_dev_configure, > .dev_infos_get = hinic_dev_infos_get, > + .fw_version_get = hinic_fw_version_get, > .rx_queue_setup = hinic_rx_queue_setup, > .tx_queue_setup = hinic_tx_queue_setup, > .dev_start = hinic_dev_start, > Patch is also updating fw version get support, can you please mention from it in the commit log? Or separate the patch..