On 9/10/2019 9:52 AM, Andrew Rybchenko wrote: > It is the sixth patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of [2], [3], [4], [5] and [6]. > > Functions which return void are bad since they do not provide explicit > information to the caller if everything is OK or not. > > In the case of MAC address get it is important to know if MAC > address is filled in or not and existing function simply keeps > it uninitialized if port ID is invalid. > > There is no driver callback to get MAC address. The driver must > fill it in in ethdev data. > > net/bonding actively uses the function but not updated to take > return value into account since it is not always obvious what > to do in the case of failure. > > Also bonding autotest and examples/bond have many lines longer > than 80 symbols and the warning is ignored on update. > > [1] https://patches.dpdk.org/patch/56969/ > [2] https://patches.dpdk.org/project/dpdk/list/?series=6279 > [3] https://patches.dpdk.org/project/dpdk/list/?series=6334 > [4] https://patches.dpdk.org/project/dpdk/list/?series=6335 > [5] https://patches.dpdk.org/project/dpdk/list/?series=6308 > [6] https://patches.dpdk.org/project/dpdk/list/?series=6350 > > Igor Romanov (7): > ethdev: change MAC addr get function return value to int > app/testpmd: check status of getting MAC address > app/pdump: check status of getting MAC address > app/test: check status of getting MAC address > app/test: check status of getting MAC address in bonding > examples: check status of getting MAC address > examples/bond: check status of getting MAC address
Series applied to dpdk-next-net/master, thanks.
