[dpdk-dev] [PATCH v2 6/7] app/testpmd: check code of allmulticast mode switch

[Andrew Rybchenko]

m>
 <1569329773-10185-1-git-send-email-arybche...@solarflare.com>

From: Ivan Ilchenko <ivan.ilche...@oktetlabs.ru>

rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return
value was changed from void to int, so this patch modify usage
of these functions across app/test-pmd
according to new return type.

Signed-off-by: Ivan Ilchenko <ivan.ilche...@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>
---
 app/test-pmd/cmdline.c | 10 ++--------
 app/test-pmd/testpmd.h |  1 +
 app/test-pmd/util.c    | 16 ++++++++++++++++
 3 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 6b9444f42..dd4e6e602 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -6603,17 +6603,11 @@ static void cmd_set_allmulti_mode_parsed(void 
*parsed_result,
        /* all ports */
        if (allports) {
                RTE_ETH_FOREACH_DEV(i) {
-                       if (enable)
-                               rte_eth_allmulticast_enable(i);
-                       else
-                               rte_eth_allmulticast_disable(i);
+                       eth_set_allmulticast_mode(i, enable);
                }
        }
        else {
-               if (enable)
-                       rte_eth_allmulticast_enable(res->port_num);
-               else
-                       rte_eth_allmulticast_disable(res->port_num);
+               eth_set_allmulticast_mode(res->port_num, enable);
        }
 }
 
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 9446d279f..c039e2961 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -825,6 +825,7 @@ void setup_gso(const char *mode, portid_t port_id);
 int eth_dev_info_get_print_err(uint16_t port_id,
                        struct rte_eth_dev_info *dev_info);
 void eth_set_promisc_mode(uint16_t port_id, int enable);
+void eth_set_allmulticast_mode(uint16_t port, int enable);
 int eth_link_get_nowait_print_err(uint16_t port_id, struct rte_eth_link *link);
 
 
diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c
index 19d36777a..ae29ee7a0 100644
--- a/app/test-pmd/util.c
+++ b/app/test-pmd/util.c
@@ -262,6 +262,22 @@ eth_set_promisc_mode(uint16_t port, int enable)
                        port, rte_strerror(-ret));
 }
 
+void
+eth_set_allmulticast_mode(uint16_t port, int enable)
+{
+       int ret;
+
+       if (enable)
+               ret = rte_eth_allmulticast_enable(port);
+       else
+               ret = rte_eth_allmulticast_disable(port);
+
+       if (ret != 0)
+               printf("Error during %s all-multicast mode for port %u: %s\n",
+                       enable ? "enabling" : "disabling",
+                       port, rte_strerror(-ret));
+}
+
 int
 eth_link_get_nowait_print_err(uint16_t port_id, struct rte_eth_link *link)
 {
-- 
2.17.1