On 9/6/2019 3:34 PM, Andrew Rybchenko wrote: > It is the third patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of the first [2] and the second [3]. > It could be applied separately, but few simple conflicts should > be resolved. > > Functions which return void are bad since they do not provide explicit > information to the caller if everything is OK or not. > It is especially painful in the case of promiscuous mode since it is > not always supported, there are real cases when it fails to apply and > it affects traffic which is received by the port. > > Driver maintainrs are encouraged to review the patch which changes > driver callbacks prototype. > > [1] https://patches.dpdk.org/patch/56969/ > [2] https://patches.dpdk.org/project/dpdk/list/?series=6222 > [3] https://patches.dpdk.org/project/dpdk/list/?series=6264 > > Igor Romanov (2): > ethdev: change xstats reset function return value to int > ethdev: make stats and xstats reset callbacks return int
For series, Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> Series applied to dpdk-next-net/master, thanks.
