On 09/23, Yang, Qiming wrote: > > [snip]
>> @@ -1378,9 +1666,18 @@ static int ice_parse_devargs(struct rte_eth_dev >> *dev) >> return -EINVAL; >> } >> >> + memset(ad->devargs.proto_xtr, PROTO_XTR_NONE, >> + sizeof(ad->devargs.proto_xtr)); >> + >> + ret = rte_kvargs_process(kvlist, ICE_PROTO_XTR_ARG, >> + &handle_proto_xtr_arg, &ad->devargs); >> + if (ret) >> + goto bail; >> + > >Why is bail? > Minor nit, better to snip unrelated context for one single comment, otherwise it's quite difficult to find it. :) Thanks, Xiaolong
