On 12/22/2015 2:56 PM, Peter Xu wrote: > On Thu, Dec 17, 2015 at 11:11:58AM +0800, Yuanhan Liu wrote: >> +static inline void __attribute__((always_inline)) >> +vhost_log_used_vring(struct virtio_net *dev, struct vhost_virtqueue *vq, >> + uint64_t offset, uint64_t len) >> +{ [...] > Got a question here: > > I see that we are logging down changes when we are marking > used_vring. Do we need to log down buffer copy in rte_memcpy() too? > I am not sure whether I understand it correctly, it seems that this > is part of DPDK API ops to deliver data to the guest (from, e.g., > OVS?), when we do rte_memcpy(), we seems to be modifying guest > memory too. Am I wrong? > > Peter
desc buffer logging isn't included in v1, but in the patch 4 of this patch set, and actually it is the major work in vhost live migration. --huawei [...]