On 9/5/19 3:25 PM, Chas Williams wrote:
[...]
>> @@ -578,7 +578,9 @@ bond_get_update_timeout_ms(void)
>> {
>> struct rte_eth_bond_8023ad_conf conf;
>>
>> - rte_eth_bond_8023ad_conf_get(test_params.bonded_port_id, &conf);
>> + if (rte_eth_bond_8023ad_conf_get(test_params.bonded_port_id, &conf) < 0)
>> + return 0;
>> +
>
> This would return a delay of 0ms, which doesn't feel like it captures
> the intent of conf_get failing. Perhaps a TEST_ASSERT_FAILURE() instead?
Chas, I've sent today reworked version. I've taken this remark into
account however TEST_ASSERT_FAILURE() is not really appropriate here
since this macro is not really an assert. It returns -1, which does not
play well with the signature of this function (return is unsigned) and
how it is used. So I've just inlined the logs.
Regards
Andrzej
