<snip> > > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error for > > armv8.2 > > > > With "-march=armv8.2-a" specified, a compiling error generated: > > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer > > expressions of different signedness: ‘unsigned int’ and ‘int’ > > [-Werror=sign-compare] > > > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Gavin Hu <gavin...@arm.com> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Reviewed-by: Steve Capper <steve.cap...@arm.com> > > > Reviewed-by: Jerin Jacob <jer...@marvell.com> This should be fixed already due to commit 104dbec2081. Gavin, can you please verify? If yes, we can skip this patch.
> > > > --- > > app/test/test_rcu_qsbr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test/test_rcu_qsbr.c b/app/test/test_rcu_qsbr.c index > > 1d273e3..b008c9d 100644 > > --- a/app/test/test_rcu_qsbr.c > > +++ b/app/test/test_rcu_qsbr.c > > @@ -231,7 +231,7 @@ test_rcu_qsbr_thread_unregister(void) > > /* Update quiescent state counter */ > > for (i = 0; i < num_threads[j]; i++) { > > /* Skip one update */ > > - if (i == (RTE_MAX_LCORE - 10)) > > + if (i == (unsigned int)(RTE_MAX_LCORE - 10)) > > continue; > > rte_rcu_qsbr_quiescent(t[0], > > (j == 2) ? (RTE_MAX_LCORE - 1) : i); > > -- > > 2.7.4