On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
> This patch adds support for MAC PAUSE flow control and priority flow
> control of hns3 PMD driver. All user priorities(up) must be mapped to
> tc0 when MAC PAUSE flow control is enabled. Ups can be mapped to other
> tcs driver permit when PFC is enabled. Flow control function by default
> is turned off to ensure that app startup state is the same each time.
As far as I can see the patch both enable DCB and flow control, can you please
either split the patch or update the commit log to cover both features?
>
> Signed-off-by: Huisong Li <lihuis...@huawei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com>
> Signed-off-by: Chunsong Feng <fengchuns...@huawei.com>
> Signed-off-by: Min Hu (Connor) <humi...@huawei.com>
> Signed-off-by: Hao Chen <chenhao...@huawei.com>
<...>
> static const struct eth_dev_ops hns3_eth_dev_ops = {
> .dev_close = hns3_dev_close,
> .mtu_set = hns3_dev_mtu_set,
> .dev_infos_get = hns3_dev_infos_get,
> .fw_version_get = hns3_fw_version_get,
> + .flow_ctrl_get = hns3_flow_ctrl_get,
> + .flow_ctrl_set = hns3_flow_ctrl_set,
> + .priority_flow_ctrl_set = hns3_priority_flow_ctrl_set,
Can you please update .ini file in this patch and mark following features as
supported:
Flow control
> .mac_addr_add = hns3_add_mac_addr,
> .mac_addr_remove = hns3_remove_mac_addr,
> .mac_addr_set = hns3_set_default_mac_addr,
> @@ -2753,6 +2949,7 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {
> .reta_update = hns3_dev_rss_reta_update,
> .reta_query = hns3_dev_rss_reta_query,
> .filter_ctrl = hns3_dev_filter_ctrl,
> + .get_dcb_info = hns3_get_dcb_info,
Can you please update .ini file in this patch and mark following features as
supported:
DCB
