Andrew Rybchenko <arybche...@solarflare.com> writes: > On 8/27/19 11:47 PM, Aaron Conole wrote: >> Andrew Rybchenko <arybche...@solarflare.com> writes: >> >>> It is the first patch series to get rid of void returning functions >>> in ethdev in accordance with deprecation notice [1]. >> This is a huge series, and I suggest to combine some of the work, and/or >> break it up. > > I can send patches for examples separately, but it will not help a lot. > I can squash changes in examples, but I think it is wrong since it would > make review harder - different maintainers and different practices to > handle error in different examples (and we tried to take it into account).
Hrrm? Not sure what you mean. Patches should be broken up by logical change. That way, it is easy to bisect and isolate what has changed. This series, it seems like there's a single logical change, and that's been spread over lots of patches. I think grouping all the examples and all the app/test together, would make the series 14 review-able patches. As it is, stepping through 40+ 10-line emails is much more tedious (not to mention needing to apply them, check each for build, etc). > Other ideas? > >> Additionally, this patch breaks the ring_pmd_autotest unit test, but I >> didn't bisect it to find out where. > > Many thanks, we'll take a look. This is actually what I'm more concerned about anyway. Please do address this.
