On 7/16/2019 4:40 PM, Stephen Hemminger wrote: > The generic RTE_LOGTYPE_PMD is a historical relic and should > not be used. Every driver should register the logtypes > for itself. > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
<...> > +#ifdef RTE_LIBRTE_E1000_DEBUG_RX > + e1000_logtype_rx = rte_log_register("pmd.net.e1000.rx"); > + if (e1000_logtype_rx >= 0) > + rte_log_set_level(e1000_logtype_rx, RTE_LOG_NOTICE); What do you think setting default level for data path log level to 'RTE_LOG_DEBUG' since they are already controlled by a config option, and to keep the behavior consistent with previous usage, because almost all macros are called with DEBUG level. Same for all drivers in this patchset.