[dpdk-dev] [PATCH v1 11/13] net/ppfe: add MTU and MAC address set operations

[Gagandeep Singh]

To update MAC address or MTU, operations are
added to the driver.

Signed-off-by: Gagandeep Singh <g.si...@nxp.com>
Acked-by: Nipun Gupta <nipun.gu...@nxp.com>
Acked-by: Akhil Goyal <akhil.go...@nxp.com>
---
 doc/guides/nics/features/ppfe.ini |  1 +
 doc/guides/nics/ppfe.rst          |  1 +
 drivers/net/ppfe/ppfe_ethdev.c    | 62 +++++++++++++++++++++++++++++++
 3 files changed, 64 insertions(+)

diff --git a/doc/guides/nics/features/ppfe.ini 
b/doc/guides/nics/features/ppfe.ini
index 9184539c1..e0406a97f 100644
--- a/doc/guides/nics/features/ppfe.ini
+++ b/doc/guides/nics/features/ppfe.ini
@@ -8,6 +8,7 @@ L3 checksum offload  = Y
 L4 checksum offload  = Y
 Packet type parsing  = Y
 Basic stats          = Y
+MTU update           = Y
 Linux VFIO           = Y
 ARMv8                = Y
 Usage doc            = Y
diff --git a/doc/guides/nics/ppfe.rst b/doc/guides/nics/ppfe.rst
index 099abfee6..b4a756258 100644
--- a/doc/guides/nics/ppfe.rst
+++ b/doc/guides/nics/ppfe.rst
@@ -94,6 +94,7 @@ PPFE Features
 - L3/L4 checksum offload
 - Packet type parsing
 - Basic stats
+- MTU update
 - ARMv8
 
 Supported PPFE SoCs
diff --git a/drivers/net/ppfe/ppfe_ethdev.c b/drivers/net/ppfe/ppfe_ethdev.c
index a98d0eda2..a354b0d44 100644
--- a/drivers/net/ppfe/ppfe_ethdev.c
+++ b/drivers/net/ppfe/ppfe_ethdev.c
@@ -6,6 +6,7 @@
 #include <rte_kvargs.h>
 #include <rte_ethdev_vdev.h>
 #include <rte_bus_vdev.h>
+#include <rte_ether.h>
 #include <of.h>
 
 #include "pfe_logs.h"
@@ -540,6 +541,58 @@ pfe_supported_ptypes_get(struct rte_eth_dev *dev)
        return NULL;
 }
 
+static int
+pfe_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
+{
+       int ret;
+       struct pfe_eth_priv_s *priv = dev->data->dev_private;
+       uint16_t frame_size = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+
+       /*TODO Support VLAN*/
+       ret = gemac_set_rx(priv->EMAC_baseaddr, frame_size);
+       if (!ret)
+               dev->data->mtu = mtu;
+
+       return ret;
+}
+
+/* pfe_eth_enet_addr_byte_mac
+ */
+static int pfe_eth_enet_addr_byte_mac(u8 *enet_byte_addr,
+                              struct pfe_mac_addr *enet_addr)
+{
+       if (!enet_byte_addr || !enet_addr) {
+               return -1;
+
+       } else {
+               enet_addr->bottom = enet_byte_addr[0] |
+                       (enet_byte_addr[1] << 8) |
+                       (enet_byte_addr[2] << 16) |
+                       (enet_byte_addr[3] << 24);
+               enet_addr->top = enet_byte_addr[4] |
+                       (enet_byte_addr[5] << 8);
+               return 0;
+       }
+}
+
+static int
+pfe_dev_set_mac_addr(struct rte_eth_dev *dev,
+                      struct rte_ether_addr *addr)
+{
+       struct pfe_eth_priv_s *priv = dev->data->dev_private;
+       struct pfe_mac_addr spec_addr;
+       int ret;
+
+       ret = pfe_eth_enet_addr_byte_mac(addr->addr_bytes, &spec_addr);
+       if (ret)
+               return ret;
+
+       gemac_set_laddrN(priv->EMAC_baseaddr,
+                        (struct pfe_mac_addr *)&spec_addr, 1);
+       rte_ether_addr_copy(addr, &dev->data->mac_addrs[0]);
+       return 0;
+}
+
 static
 int pfe_stats_get(struct rte_eth_dev *dev,
                         struct rte_eth_stats *stats)
@@ -571,6 +624,8 @@ static const struct eth_dev_ops ops = {
        .tx_queue_setup = pfe_tx_queue_setup,
        .tx_queue_release  = pfe_tx_queue_release,
        .dev_supported_ptypes_get = pfe_supported_ptypes_get,
+       .mtu_set              = pfe_mtu_set,
+       .mac_addr_set         = pfe_dev_set_mac_addr,
        .stats_get            = pfe_stats_get,
 };
 
@@ -583,6 +638,7 @@ static int pfe_eth_init(struct rte_vdev_device *vdev, 
struct pfe *pfe, int id)
        struct pfe_eth_priv_s *priv = NULL;
        struct ls1012a_eth_platform_data *einfo;
        struct ls1012a_pfe_platform_data *pfe_info;
+       struct rte_ether_addr addr;
        int err;
 
        if (id >= pfe->max_intf) {
@@ -648,6 +704,12 @@ static int pfe_eth_init(struct rte_vdev_device *vdev, 
struct pfe *pfe, int id)
                goto err0;
        }
 
+       memcpy(addr.addr_bytes, priv->einfo->mac_addr,
+                      ETH_ALEN);
+
+       pfe_dev_set_mac_addr(eth_dev, &addr);
+       rte_ether_addr_copy(&addr, &eth_dev->data->mac_addrs[0]);
+
        eth_dev->data->mtu = 1500;
        eth_dev->dev_ops = &ops;
        pfe_eth_stop(eth_dev);
-- 
2.17.1