On Mon, Aug 12, 2019 at 12:25:03PM +0100, Wiles, Keith wrote:
> 
> 
> > On Aug 12, 2019, at 1:53 AM, David Marchand <david.march...@redhat.com> 
> > wrote:
> > 
> > Restrict this header inclusion to its real users.
> > 
> > Fixes: 028669bc9f0d ("eal: hide shared memory config")
> > 
> > Signed-off-by: David Marchand <david.march...@redhat.com>
> 
> The only thing I would suggest is to add the name of the header file in the 
> subject or body of the commit, as currently it is not obvious reading the 
> commit title or body.
> 
> Regards,
> Keith

+1

Reply via email to