On 23/08/2019 11:01, Kevin Traynor wrote:
On 02/07/2019 15:20, Flavia Musatescu wrote:Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change additional warnings are turned on to be treated as errors, which causes the following build issues to be seen: - no previous prototype [-Werror=missing-prototypes] - initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] - old-style function definition [-Werror=old-style-definition] - variable may be used before its value is set (when using icc compiler). Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats") Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets") Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") Fixes: fff6df7bf58e ("telemetry: fix using ports of different types") Fixes: 4080e46c8078 ("telemetry: support global metrics") Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan <reshma.pat...@intel.com> Signed-off-by: Flavia Musatescu <flavia.musate...@intel.com>Hi Flavio, in the 18.11. stable branch, I had "fixed" the gcc9 warnings in telemetry with 2ae7bca9594d ("mk: disable packed member pointer warning for telemetry") This patch in 18.11 branch is causing the following build error: /root/lts/dpdk-18.11/lib/librte_telemetry/rte_telemetry.c:1822:13: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] .opt_str = "--telemetry", ^~~~~~~~~~~~~ I'm inclined to just keep the existing existing patch in stable and not apply this one. Or if you want to do a backport for 18.11 branch that is ok too. WDYT?
Hi Kevin, I will backport the patch for 18.11. Thanks
