> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pavel Fedin
> Sent: Tuesday, December 15, 2015 10:21 PM
> To: 'Yuanhan Liu'
> Cc: dev at dpdk.org; 'Ilya Maximets'; 'Dyasly Sergey'
> Subject: Re: [dpdk-dev] problem vhost-user sockets
>
> Hello!
>
> > I'm thinking you can't simply unlink a file given by a user inside
> > a libraray unconditionaly. Say, what if a user gives a wrong socket
> > path?
Exactly, Yuanhan. The initial thinking is it is the user's responsibility to
provide a clean running environment and I try to avoid the dpdk app touch
something that others might be using.
>
> Well... We can improve the security by checking that:
>
> a) The file exists and it's a socket.
> b) Nobody is listening on it.
>
> > I normally write a short script to handle it automatically.
Yes, the same to me.
>
> I know, you can always hack up some kludges, just IMHO it's not
> production-grade solution. What if you are cloud administrator, and
> you have 1000 users, each of them using 100 vhost-user interfaces?
> List all of them in some script? Too huge job, i would say.
> And without it the thing just appears to be too fragile, requiring
> manual maintenance after a single stupid failure.
Pavel:
I totally understand your pain, it also brings trouble to ourselves when
debugging, but I want to follow the best practice. Btw I don't see the trouble
with the script here. The users should know clearly where and how to do the
cleanup. Normally the socket files should all reside in one single directory.
For the checking you mentioned above, even the existing file has nobody
listening on it, in theory there is no guarantee others might not use it. Of
course, for this specific case, the chance is rare.
>From another point of view, DPDK huge re-creates rte_map files even if it
>exists. :).
We are open to this. Let us consider more and gather more comments.
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
