> -----Original Message-----
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, August 21, 2019 12:33 AM
> To: Van Haaren, Harry <harry.van.haa...@intel.com>
> Cc: dev@dpdk.org; Stephen Hemminger <step...@networkplumber.org>
> Subject: [PATCH] service: print errors to rte log
>
> EAL should always use rte_log instead of putting errors to
> stderr (which maybe redirected to /dev/null in a daemon).
>
> Also checks for null before rte_free are unnecessary.
>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
Thanks - good improvements.
A few nit-picks, I'll send a v2 based on your changes here with
the below notes implemented.
I'll add my Sign-off for code changes, and Acked-by for the whole,
hope that's OK, if you'd prefer two different patches just let me know.
-H
> ---
> lib/librte_eal/common/rte_service.c | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index c3653ebae46c..aa2f8f3ef4b1 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -70,10 +70,12 @@ static struct rte_service_spec_impl *rte_services;
> static struct core_state *lcore_states;
> static uint32_t rte_service_library_initialized;
>
> +
> int32_t rte_service_init(void)
> {
Added line here should really split return-value and function into
two lines. Found another instance of this, splitting that too to make
the whole file consistent.
Rest of file uses 1 line to split variable declarations and functions,
so one line will do.
<snip>
> if (!rte_services) {
> - printf("error allocating rte services array\n");
> + RTE_LOG(ERR, EAL,
> + "error allocating rte services array\n");
> goto fail_mem;
Some of these "strings" can be on the same line as RTE_LOG and stay
inside the 80 char limit, moving them up a line for consistency.
