On 12-Aug-19 10:49 AM, David Marchand wrote:
On Mon, Aug 12, 2019 at 11:43 AM Burakov, Anatoly
<anatoly.bura...@intel.com> wrote:
On 08-Aug-19 8:31 AM, Thomas Monjalon wrote:
I would suggest to restrict the change to Arm only with an ifdef,
in order to limit the risk for this release.
We can think about a dynamic hugepage scan in the next release.
I don't see how this is necessary. The 3 is an arbitrary number here,
and the ABI isn't broken as this is an internal structure. We could
increase it to 16 for all i care, and it wouldn't make any difference to
the rest of the code - we never populate more than we can find anyway.
I agree on the principle.
But at the time this popped up, we were really close to the release.
It seemed a way to mitigate any unforeseen issue by limiting to the
platform that was affected.
Fair enough. A follow up is needed so. Frankly, i don't see the need to
complicate things with "dynamic" stuff here - a static array of 8 or 16
page sizes should be enough for everyone (TM).
--
Thanks,
Anatoly
