06/08/2019 16:45, Ananyev, Konstantin: > From: Thomas Monjalon > > 04/07/2019 06:43, simei: > > > From: Simei Su <simei...@intel.com> > > > > > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This > > > can support symmetric hash function by rte_flow RSS action. > > > > > > Signed-off-by: Simei Su <simei...@intel.com> > > > --- > > > +* ethdev: New member in ``rte_eth_hash_funtion`` to support symmetric > > > hash funtion. > > > > That's unfortunate there is a typo in the name of the enum you want to > > change. > > > > Do you have any reference to the algo you want to support? A paper maybe? > > If I am not mistaken that's just an intent to enable symmetric RSS > hash-function via standard RSS rte_flow API - > feature already available with i40e and newest Intel HW. > (AFAIK on i40e right now it could be configured via > RTE_ETH_HASH_FILTER_SYM_HASH_ENA_PER_PORT). > If so, then I think the author may need to mention what PMDs will support > that feature in 19.11.
Without any more comment, this patch cannot be accepted in 19.08.
