06/08/2019 13:24, Thomas Monjalon: > 23/07/2019 16:22, Ferruh Yigit: > > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > > void return value is bad for get API (like rte_eth_dev_info-get()) > > > since caller does not know if the function does its job or not and > > > output value is filled in. > > > > > > void return value is bad for state changing API (like > > > rte_eth_promiscuous_enable()) since caller should use get API > > > to understand if state is really changed. > > > > > > Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> > Acked-by: Thomas Monjalon <tho...@monjalon.net> > Acked-by: Jerin Jacob <jer...@marvell.com>
Applied, thanks