On 08/05, Xiaoyun Li wrote:
>This patch adds return value checking for fseek function to fix
>error handling issue found by coverity scan.
>
>Coverity issue: 344996
>Fixes: c5eebf85badc ("examples/ntb: add example for NTB")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Xiaoyun Li <xiaoyun...@intel.com>
>---
> examples/ntb/ntb_fwd.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/examples/ntb/ntb_fwd.c b/examples/ntb/ntb_fwd.c
>index c169f01a3..f8c970cdb 100644
>--- a/examples/ntb/ntb_fwd.c
>+++ b/examples/ntb/ntb_fwd.c
>@@ -125,9 +125,15 @@ cmd_sendfile_parsed(void *parsed_result,
> return;
> }
>
>- fseek(file, 0, SEEK_END);
>+ if (fseek(file, 0, SEEK_END) < 0) {
>+ printf("Fail to get file size.\n");
>+ return;
>+ }
> size = ftell(file);
>- fseek(file, 0, SEEK_SET);
>+ if (fseek(file, 0, SEEK_SET) < 0) {
>+ printf("Fail to get file size.\n");
>+ return;
>+ }
>
> /**
> * No FIFO now. Only test memory. Limit sending file
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong...@intel.com>
