31/07/2019 22:54, Michael Santana Francisco: > On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole <acon...@redhat.com> wrote: > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > @@ -22,3 +22,11 @@ fi > > OPTS="$OPTS --default-library=$DEF_LIB" > > meson build --werror -Dexamples=all $OPTS > > ninja -C build > > + > > +if [ "$RUN_TESTS" = "1" ]; then > > + # On the test build, also build the documentation, since it's expensive > > + # and we shouldn't need to build so much of it. > > + ninja -C build doc
I am not sure to understand the comment. Do you mean you build the documentation only once, which is when running tests? Why it is not a new option similar as RUN_TESTS? > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -30,6 +30,7 @@ env: > > - DEF_LIB="shared" > > - DEF_LIB="static" OPTS="-Denable_kmods=false" > > - DEF_LIB="shared" OPTS="-Denable_kmods=false" > > + - DEF_LIB="shared" RUN_TESTS=1 > I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on > an already exiting builds instead of adding two new builds like you > are doing here? I agree it is a strange logic. Why not use an existing build to run the tests?
