Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix unaligned memory access

[Ruifeng Wang (Arm Technology China)]

> -----Original Message-----
> From: David Christensen <d...@linux.vnet.ibm.com>
> Sent: Wednesday, July 31, 2019 01:45
> To: jer...@marvell.com; Bruce Richardson <bruce.richard...@intel.com>;
> tho...@monjalon.net
> Cc: dev@dpdk.org; sta...@dpdk.org; hgovindh
> <hariprasad.govindhara...@intel.com>; Marko Kovacevic
> <marko.kovace...@intel.com>; Ori Kam <or...@mellanox.com>; Pablo de
> Lara <pablo.de.lara.gua...@intel.com>; Radu Nicolau
> <radu.nico...@intel.com>; akhil.go...@nxp.com; Tomasz Kantecki
> <tomasz.kante...@intel.com>; Ruifeng Wang (Arm Technology China)
> <ruifeng.w...@arm.com>; maciej.cze...@caviumnetworks.com
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] examples/l3fwd: fix
> unaligned memory access
> 
> >> On Tue, Jul 30, 2019 at 10:50:14AM +0200, Thomas Monjalon wrote:
> >>> Review please?
> >>>
> >>> 26/07/2019 15:58, hgovindh:
> >>>> Fix unaligned memory access when reading IPv6 header which leads to
> >>>> segmentation fault by changing aligned memory read to unaligned
> >>>> memory read.
> >>>>
> >>>> Bugzilla ID: 279
> >>>> Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build")
> >>>> Cc: maciej.cze...@caviumnetworks.com
> >>>> Cc: sta...@dpdk.org
> >>>> Signed-off-by: hgovindh <hariprasad.govindhara...@intel.com>
> >>>> --- a/examples/l3fwd/l3fwd_em.c
> >>>> +++ b/examples/l3fwd/l3fwd_em.c
> >>>> +#if defined RTE_ARCH_X86
> >>>> +        key.xmm[1] = _mm_loadu_si128(data1); #else
> >>>>          key.xmm[1] = *(xmm_t *)data1;
> >>>> -
> >>>> +#endif
> >>>
> >>
> >> The blank line should be re-added below the #ifdef. Apart from that
> >> the fix looks correct to me.
> >>
> >> Reviewed-by: Bruce Richardson <bruce.richard...@intel.com>
> > Reviewed-by: Jerin Jacob <jer...@marvell.com>
> Reviewed-by: David Christensen <d...@linux.vnet.ibm.com>
Reviewed-by: Ruifeng Wang <ruifeng.w...@arm.com>