On 7/24/2019 4:35 PM, Xiaolong Ye wrote: > This patch adds support to allow users enable/disable allmulticast mode for > kni interface. > > This requirement comes from bugzilla 312, more details can refer to: > https://bugs.dpdk.org/show_bug.cgi?id=312 > > Bugzilla ID: 312 > > Signed-off-by: Xiaolong Ye <xiaolong...@intel.com>
Hi Xiaolong, Patch lgtm, I think it is too later for this release but I suggest sending v1 for next release. If there is an ABI breakage, to not block the patch for next release, a deprecation notice needs to be sent in this release. Although the patch updates header file, as far as I can see it doesn't break the ABI, since added fields either last element of the struct or the part of the union. But to be sure, can you please double check if I am missing something?
