On Wed, Jul 17, 2019 at 5:53 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > In order to ease basic testing with customized options, > EAL and testpmd options can be added as third and fourth arguments > of the "null PMD" script. > > Also, the first argument becomes more flexible by accepting > the testpmd path as an alternative to the build directory. > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > --- > devtools/test-null.sh | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/devtools/test-null.sh b/devtools/test-null.sh > index 6928a6c15..69eddc359 100755 > --- a/devtools/test-null.sh > +++ b/devtools/test-null.sh > @@ -5,10 +5,13 @@ > > # Run a quick testpmd forwarding with null PMD without hugepage > > -build=${1:-build} > +build=${1:-build} # first argument can be the build directory > +testpmd=$1 # or first argument can be the testpmd path > coremask=${2:-3} # default using cores 0 and 1 > +eal_options=$3 > +testpmd_options=$4 > > -testpmd=$build/app/dpdk-testpmd > +[ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd > [ -f "$testpmd" ] || testpmd=$build/app/testpmd > if [ ! -f "$testpmd" ] ; then > echo 'ERROR: testpmd cannot be found' >&2 > @@ -22,5 +25,5 @@ fi > > (sleep 1 && echo stop) | > $testpmd -c $coremask --no-huge -m 150 \ > - $libs --vdev net_null1 --vdev net_null2 -- \ > - --no-mlockall --total-num-mbufs=2048 -ia > + $libs --vdev net_null1 --vdev net_null2 $eal_options -- \ > + --no-mlockall --total-num-mbufs=2048 $testpmd_options -ia > -- > 2.21.0 >
Not sure I would have split this from the first patch. Out of curiosity, what are the cases where you need to set options? -- David Marchand