> -----Original Message----- > From: Jerin Jacob Kollanukkaran <jer...@marvell.com> > Sent: Tuesday, July 23, 2019 12:57 AM > To: Phil Yang (Arm Technology China) <phil.y...@arm.com>; dev@dpdk.org > Cc: tho...@monjalon.net; gage.e...@intel.com; > hemant.agra...@nxp.com; Honnappa Nagarahalli > <honnappa.nagaraha...@arm.com>; Gavin Hu (Arm Technology China) > <gavin...@arm.com>; nd <n...@arm.com> > Subject: RE: [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare > exchange > > > -----Original Message----- > > From: Phil Yang <phil.y...@arm.com> > > Sent: Monday, July 22, 2019 9:53 PM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran > <jer...@marvell.com>; > > gage.e...@intel.com; hemant.agra...@nxp.com; > > honnappa.nagaraha...@arm.com; gavin...@arm.com; n...@arm.com > > Subject: [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare > > exchange > > > > Add 128-bit atomic compare exchange on aarch64. > > > > Suggested-by: Jerin Jacob <jer...@marvell.com> > > Signed-off-by: Phil Yang <phil.y...@arm.com> > > Tested-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > > > --- > > diff --git a/config/common_base b/config/common_base index > > 8ef75c2..de6d1e0 100644 > > --- a/config/common_base > > +++ b/config/common_base > > @@ -82,6 +82,8 @@ CONFIG_RTE_MAX_LCORE=128 > > CONFIG_RTE_MAX_NUMA_NODES=8 > > CONFIG_RTE_MAX_HEAPS=32 > > CONFIG_RTE_MAX_MEMSEG_LISTS=64 > > > Add new line here. > > > +# Use LSE ATOMIC instructions > > I think, you can change the comment to "Use ARM LSE ATOMIC instructions"
OK. Will fix it. > > > +CONFIG_RTE_ARM_FEATURE_ATOMICS=n > > This patches series has following check patch warning. Please fix it > > With above fixes you can add my acked-by in 1/3 and 3/3 patches in next > revision. Thank you for your review and your comments. > > > I think, you can ignore following warning. > WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control > statements should be avoided > > [master]dell[dpdk.org] $ ./devtools/checkpatches.sh Yes. I did this check before upstream this patch. I ignored ' WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided ' warnings. However, I didn't see any LONG_LINE warnings in the CI report here. http://mails.dpdk.org/archives/test-report/2019-July/090889.html BTW, I think these 3 warnings in the report might be ineluctable. > > ### eal/arm64: add 128-bit atomic compare exchange > > WARNING:LONG_LINE: line over 80 characters The default tab size is 8. You might need to change it to 4 in the /usr/src/linux/scripts/checkpatch tool. FYI. diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a09333f..d3865a4 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1211,7 +1211,7 @@ sub expand_tabs { if ($c eq "\t") { $res .= ' '; $n++; - for (; ($n % 8) != 0; $n++) { + for (; ($n % 4) != 0; $n++) { $res .= ' '; } next; @@ -3688,11 +3688,11 @@ sub process { #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n"; if ($check && $s ne '' && - (($sindent % 8) != 0 || + (($sindent % 4) != 0 || ($sindent < $indent) || ($sindent == $indent && ($s !~ /^\s*(?:\}|\{|else\b)/)) || - ($sindent > $indent + 8))) { + ($sindent > $indent + 4))) { WARN("SUSPECT_CODE_INDENT", "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n"); } > #103: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:60: > + rte_int128_t updated) > \ > > WARNING:LONG_LINE: line over 80 characters > #108: FILE: lib/librte_eal/common/include/arch/arm/rte_atomic_64.h:65: > + */ > \
