22/07/2019 16:57, Ferruh Yigit: > On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > From: Lance Richardson <lance.richard...@broadcom.com> > > --- a/config/common_base > > +++ b/config/common_base > > @@ -212,6 +212,7 @@ CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n > > # Compile burst-oriented Broadcom BNXT PMD driver > > # > > CONFIG_RTE_LIBRTE_BNXT_PMD=y > > +CONFIG_RTE_LIBRTE_BNXT_SHARED_ASYNC_RING=n > > Normally we don't want to introduce new config time options as much as > possible. > > This is what happens when patches slip in the last minute, please Ajit try to > send patches before proposal next time. > > And back to the config option, is it something have to be a compile time flag > (if so why?), can it be replaced by a devarg?
I confirm it is nack. I don't see any reason not to replace it with a runtime devargs.
