> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusz...@intel.com>
> Sent: Thursday, July 18, 2019 6:39 PM
> To: Shally Verma <shal...@marvell.com>; Nowak, DamianX
> <damianx.no...@intel.com>; dev@dpdk.org
> Cc: akhil.go...@nxp.com; Trahe, Fiona <fiona.tr...@intel.com>
> Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in
> asymmetric crypto
>
> External Email
>
> ----------------------------------------------------------------------
> > > >
> > > > Split into smaller commits, in order from least disputable ones.
> > > > Open things beside this:
> > > > 1. Creating padding struct
> > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading
> > > > zeroes questions.
> > > > 4. Random number requirements.
> > > > 5. Capabilities.
> > > > 6. Verify signature field when none padding.
> > > >
> > > > v4:
> > > > - change API comments from length -> array allocation to avoid
> > > > ambiguity
> > > >
> > > > v3:
> > > > - split into smaller patches
> > > > - removed padding struct changes
> > > > - rebased against patches from CRT patches from Ayuj Verma
> > > >
> > > > v2:
> > > > - Field for singature verification when padding none selected was
> > > > added
> > > > - Removed details from RFC
> > > > - Simplified padding struct
> > > > - Added padding none test case
> > > >
> > > > This patchset depends on following patches:
> > > > [1]
> > > > test/crypto: move rsa enqueue/dequeue into separate functions
> > > > (http://patchwork.dpdk.org/patch/56342/)
> > > > [2]
> > > > test/crypto: add tests for RSA key type CRT
> > > > (http://patchwork.dpdk.org/patch/56343/)
> > > >
> > > > Arek Kusztal (11):
> > > > cryptodev: change RSA API comments about primes
> > > > cryptodev: add cipher field to RSA op
> > > > crypto/openssl: add cipher field to openssl RSA implementation
> > > > test: add cipher field to RSA test
> > > > cryptodev: add information about message format when signing
> > > > with
> > RSA
> > > > cryptodev: remove RSA PKCS1 BT0 padding
> > > > openssl: remove RSA PKCS1_5 BT0 padding
> > > > test: remove RSA PKCS1_5 BT0 padding from test cases
> > > > cryptodev: add RSA padding none description
> > > > test: add pkcs1_5 padding simulation
> > > > test: add RSA PKCS1_5 padding case when no padding selected
> > > >
> > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++--
> ----
> > > > app/test/test_cryptodev_asym_util.h | 54
> > > > +++++++++++++++++++++++++++
> > > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++---
> > > > lib/librte_cryptodev/rte_crypto_asym.h | 64
> > > > ++++++++++++++++++++++++--------
> > > > 4 files changed, 149 insertions(+), 34 deletions(-)
> > > >
> > > > --
> > > > 2.1.0
> > >
> > > Series-acked-by: Damian Nowak <damianx.no...@intel.com>
> > I had ack'd some. But others which are Nack'd , we need more time for
> them.
> > So, from my end, which are Ack'd good to go but other need to wait.
>
> As I generally agree that we need far more time to get all things done, I
> would like to know what is current situation:
>
> We should apply
> 1) Cipher field
I assume I acked it with some improvement requirement on description. Let me
know if I did not.
> 2) Remove BT0
>
> We should still discuss (possibly 19.11)
> 1) Signature input format
> 2) None padding
>
[Shally] Yes but sorry I don't recall if it covers all patches I Nack'd . I ,
specifically, Acked some ,which are good to go.
> Is this correct?
>
>
>
> >
> > Thanks
> > Shally
