On 7/16/2019 12:39 PM, Viacheslav Ovsiienko wrote: > The DEV_TX_OFFLOAD_MATCH_METADATA was introduced by [1], but > it is not displayed by "show port [id] tx_offloads capabilities" > command in testpmd. > > [1] http://patches.dpdk.org/patch/47265/ > > Fixes: 839b20be0e9b ("ethdev: support metadata as flow rule criteria") > Cc: sta...@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko <viachesl...@mellanox.com> > --- > app/test-pmd/config.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index ba43be5..8fb18be 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -830,6 +830,14 @@ > printf("off\n"); > } > > + if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MATCH_METADATA) { > + printf("TX match Flow metafata: "); > + if (ports[port_id].dev_conf.txmode.offloads & > + DEV_TX_OFFLOAD_MATCH_METADATA) > + printf("on\n"); > + else > + printf("off\n"); > + } > } > > int >
Hi Viacheslav, There is already another testpmd command that displays offloads, which is more dynamic and I think better solution: "show port <port_id> tx_offload capabilities" "show port <port_id> tx_offload configuration" "show port <port_id> rx_offload capabilities" "show port <port_id> rx_offload configuration" As far as I can see 'metadata' already supported by these commands, can you please confirm? And instead of improving it, what do you think dropping the duplicated command "show port cap <port_id>|all" ?
