Regards
Sunil Kumar Kori
>-----Original Message-----
>From: Thomas Monjalon <tho...@monjalon.net>
>Sent: Tuesday, July 16, 2019 4:52 PM
>To: Sunil Kumar Kori <sk...@marvell.com>
>Cc: dev@dpdk.org; Konstantin Ananyev <konstantin.anan...@intel.com>;
>Jerin Jacob Kollanukkaran <jer...@marvell.com>
>Subject: Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove
>PKT_TX_IP_CKSUM offload flags
>
>16/07/2019 08:23, Sunil Kumar Kori:
>> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during
>> fragmentation operation implicitly by the library. Because of this,
>> application is forced to use checksum offload whether it is supported
>> by platform or not.
>>
>> Also documentation does not provide any expected value of ol_flags in
>> returned fragmented mbufs so application will never come to know that
>> which offloads are enabled. So transmission may be failed for the
>> platforms which does not support checksum offload.
>>
>> So removing mentioned flag from the library.
>>
>> Mentioned changeset is part of http://patches.dpdk.org/patch/53475/
>> Changes for reassembly operation is already accepcted. This patch set
>> implements the similar change for fragmentation operation.
>>
>> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
>
>Sunil, I would really appreciate you take care of the formatting.
>The previous patch had a changed title to comply some coding style:
> e29fc4437 ip_frag: remove IP checkum offload flag
>It requires also this line:
> Fixes: e29fc44370c2 ("ip_frag: remove IP checkum offload flag") When
>sending a new version, you are supposed to:
> - add a changelog
> - use --in-reply-to
>
>Applied
>
Thanks.
Its my bad that I forgot to send next version with "--in-reply-to" and shared
as a new patch.
I will take care of suggestions in future patches.
