10/07/2019 16:16, Konstantin Ananyev: > With latest changes l3fwd_simple_forward() blindly set > (PKT_TX_IPV4 | PKT_TX_IP_CKSUM) ol_flags for all IPv4 packets. > Though for un-fragmented packets we also do have to set l3_len > to make HW IP cksum offload to work properly. > That causes HWi/PMD to drop or generate invalid packets. > Though for un-fragmented packets we don't need to regenerate > IPv4 cksum, as L3 header is not modified. > Fix by setting ol_flags only when required. > Another small fix - don't set IPv4/IPV6 ether type for unknown > packet types. > > Fixes: 16863bbb4a41 ("examples/ip_fragmentation: enable IP checksum offload")
Shouldn't it be 2 separate fixes?