16/07/2019 10:24, David Hunt: > replace strcpy with strlcpy to prevent buffer overrun > With fix, attempting to use a VERY lonng vm name results in a nicely > truncated 32 character name rather than a segfault: > Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd] > > Using strlcpy rather than rte_strlcpy, as the rte_ version is only a > fallback. > > As well as the fix in main.c, this patch also changes an occurrence of > rte_strlcpy in channel_manager.c and channel_monitor.c to strlcpy. [...] > --- a/examples/vm_power_manager/guest_cli/main.c > +++ b/examples/vm_power_manager/guest_cli/main.c > - strcpy(policy->vm_name, optarg); > + rte_strlcpy(policy->vm_name, optarg, VM_MAX_NAME_SZ);
This is still using rte_strlcpy !!