11/07/2019 09:46, Ferruh Yigit: > On 7/10/2019 9:09 PM, Ferruh Yigit wrote: > > On 6/25/2019 4:04 PM, Yangchao Zhou wrote: > >> va2pa depends on the physical address and virtual address offset of > >> current mbuf. It may get the wrong physical address of next mbuf which > >> allocated in another hugepage segment. > >> > >> In rte_mempool_populate_default(), trying to allocate whole block of > >> contiguous memory could be failed. Then, it would reserve memory in > >> several memzones that have different physical address and virtual address > >> offsets. The rte_mempool_populate_default() is used by > >> rte_pktmbuf_pool_create(). > >> > >> Fixes: 8451269e6d7b ("kni: remove continuous memory restriction") > >> > >> Signed-off-by: Yangchao Zhou <zhouya...@gmail.com> > > > > Overall looks good to me, not from this patch but can you please check below > > comment too. > > Also there is a comment from Junxiao, lets clear it before the ack. > > > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com>
The commit log does not really explained neither the use case nor the solution. But as you acked it... Applied, thanks