Hi Fan/Liron, Could you please send the incremental patch ASAP. Otherwise I need to remove this patch from the subtree. I don't have environment to test this.
Regards, Akhil > > Hi Fan, > > > > > 08/07/2019 12:26, Thomas Monjalon: > > > 07/07/2019 07:41, Liron Himi: > > > > From: Akhil Goyal <akhil.go...@nxp.com> > > > > > This patch fixes the missed "uint8_t *" to "const uint8_t *" xform key > > > > > data type change for mvsam driver. > > > > > > > > > > Fixes: f3390532cf6a ("cryptodev: make xform key pointer constant") > > > > > > > > > > Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com> > > > > > --- > > > > Based on Fan's comments > > > > > > > > acked-by: Liron Himi <lir...@marvell.com> > > > > > > So we are OK to merge this patch with > > > "cryptodev: make xform key pointer constant" > > > in next-crypto tree? > > > > There is still a compilation error: > > > > drivers/crypto/mvsam/rte_mrvl_pmd.c:267:41: error: > > incompatible type for argument 2 of 'memcpy' > > memcpy(cipher_key, cipher_xform->cipher.key, > > ~~~~~~~~~~~~~~~~~~~~^~~~ > > > > Seen when compiling arm64-thunderx-linux-gcc > > > > Could you send a proper fix to this issue. > > Thanks, > Akhil