Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during fragmentation and reassemble operation implicitly. Because of this, application is forced to use checksum offload whether it is supported by platform or not.
Also documentation does not provide any expected value of ol_flags in returned mbuf (reassembled or fragmented) so application will never come to know that which offloads are enabled. So transmission may be failed for the platforms which does not support checksum offload. So removing mentioned flag from the library. Signed-off-by: Sunil Kumar Kori <sk...@marvell.com> --- Current patch is part of following patchset http://patches.dpdk.org/patch/53475/ which is missed to be merged into upstream because of accepted version of this patch does not contain this change. Accepted patchset is given below: http://patches.dpdk.org/patch/56202/ Patchset is already reviewed and acked on maillist. Also corrersponding release notes are updated. lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c index 221d74e..9e9f986 100644 --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c @@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num) fragment_offset = (uint16_t)(fragment_offset + out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr)); - out_pkt->ol_flags |= PKT_TX_IP_CKSUM; out_pkt->l3_len = sizeof(struct rte_ipv4_hdr); /* Write the fragment to the output list */ -- 1.8.3.1
