Hi Qi, I will do it in v3. Thanks
-----Original Message----- From: Zhang, Qi Z Sent: Sunday, June 30, 2019 8:36 AM To: Pei, Andy <andy....@intel.com>; dev@dpdk.org Cc: Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com>; Yigit, Ferruh <ferruh.yi...@intel.com>; Xu, Rosen <rosen...@intel.com>; Ye, Xiaolong <xiaolong...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; sta...@dpdk.org Subject: RE: [PATCH v2] net/i40e: i40e get link status update from ipn3ke > -----Original Message----- > From: Pei, Andy > Sent: Friday, June 28, 2019 4:33 PM > To: dev@dpdk.org > Cc: Pei, Andy <andy....@intel.com>; Zhang, Qi Z > <qi.z.zh...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Xing, > Beilei <beilei.x...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Xu, Rosen <rosen...@intel.com>; Ye, Xiaolong > <xiaolong...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; > sta...@dpdk.org > Subject: [PATCH v2] net/i40e: i40e get link status update from ipn3ke > > Add switch_mode argument for i40e PF to specify the specific FPGA that > i40e PF is connected to. i40e PF get link status update via the connected > FPGA. > > Signed-off-by: Andy Pei <andy....@intel.com> > --- .... > @@ -2799,6 +2913,10 @@ void i40e_flex_payload_reg_set_default(struct > i40e_hw *hw) > else > update_link_aq(hw, &link, enable_lse, wait_to_complete); > > + devargs = pci_dev->device.devargs; > + if (devargs) > + i40e_pf_linkstatus_get_from_switch_ethdev(devargs, &link); It's not necessary to check devargs every time we do i40e_dev_link_update, its better initialize the ipn3ke mode during initialization (add some field in i40e_adapter maybe), so we can reuse the result at runtime > + ......
