On Thu, Dec 10, 2015 at 11:46:50AM +0530, Santosh Shukla wrote: > On Tue, Dec 8, 2015 at 6:29 PM, Xie, Huawei <huawei.xie at intel.com> wrote: > > > > > >> -----Original Message----- > >> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > >> Sent: Monday, December 07, 2015 10:12 AM > >> To: Santosh Shukla > >> Cc: dev at dpdk.org; thomas.monjalon at 6wind.com; Xie, Huawei > >> Subject: Re: [PATCH 0/6] Add virtio support in arm/arm64 > >> > >> On Fri, Dec 04, 2015 at 11:05:13PM +0530, Santosh Shukla wrote: > >> > This patch set add basic infrastrucure to run virtio-net-pci pmd driver > >> for > >> > arm64/arm. Tested on ThunderX platfrom. Verified for existing dpdk(s) > >> test > >> > applications like: > >> > - ovs-dpdk-vhost-user: across the VM's, for the use-cases like > >> guest2guest and > >> > Host2Guest > >> > - testpmd application: Tested for max virtio-net-pci interface currently > >> > supported in kernel i.e. 31 interface. > >> > >> > >> Hi Santosh, > >> > >> Here is a quick notice that I don't have time to review your patches > >> this one or two weeks. Sorry for that. > >> > >> (Not quite sure Huawei has the bandwidth or not, btw) > > Sorry, just back from vocation. We will review your patch. > > Ping, > > I have started working on V2 patch set based on review comment so far > received. It would be great if I get your review comment too. > > Also few of my patch code base changes for V2 version gonna overlap > with Yuanhan latest virtio 1.0 patch set titled "[dpdk-dev] [PATCH 0/6 > for 2.3] initial virtio 1.0 enabling ", Specially patch 4 and 5. So I > would appreciate any review feedback. That avoid overlapping for me. > Some questions though: > - Shall I rebase Yuanhan's virtio 1.0 patch set, then start v2? By
No, you should not develop v2 based on my virtio 1.0 support patchset; it's in a very rough state, and it will not be applied soon: it's for v2.3, and v2.2 is not relased yet. So, I would suggest you (always) to make patches based on the latest git: rebasing (if necessary) won't be too hard after all, especially for small patch set. > doing that I could leverage "viritio: switch to 64 bit features". In > this patch series, I did took care of 32 bit vs 64 bit changes for > arm64 case. I'd suggest you to send v2, with all comments addressed. I will try to find a time reviewing your patches next week, to see what I can help :) --yliu