Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, July 3, 2019 11:05 AM > To: Ananyev, Konstantin <konstantin.anan...@intel.com>; Iremonger, > Bernard <bernard.iremon...@intel.com>; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for > inline crypto > > Hi Bernard, > > > > > > > Inline crypto installs a flow rule in the NIC. This flow rule must > > > be installed before the first inbound packet is received. > > > > > > The create_session() function installs the flow rule, > > > create_session() has been refactored into create_inline_session() > > > and create_lookaside_session(). The create_inline_session() function > > > uses the socket_ctx data and is now called at initialisation in > > > sa_add_rules(). > > > > > > The max_session_size() function has been added to calculate memory > > > requirements. > > > > > > The cryprodev_init() function has been refactored to drop calls to > > > rte_mempool_create() and to drop calculation of memory requirements. > > > > > > The main() function has been refactored to call max_session_size() > > > and to call session_pool_init() and session_priv_pool_init() earlier. > > > The ports are started now before adding a flow rule in main(). > > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions are > > > now called after the ports have been started. > > > > > > The rte_ipsec_session_prepare() function is called in > > > fill_ipsec_session() for inline which is called from the ipsec_sa_init() > function. > > > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security > > > offload") > > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample > > > application") > > > Cc: sta...@dpdk.org > > > > > > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com> > > > --- > > > > Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > Tested-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > > > This patch need to be rebased. > > However, I will try to work on your v5 in next few days if I get time. If I > don't > get time to fix that, will need you to send a rebased version of this patch. > > Thanks, > Akhil >
v6 is the latest version I will send a v7 rebased on 19.08.rc1 Regards, Bernard
