>From: David Marchand <david.march...@redhat.com> >Sent: Wednesday, June 26, 2019 1:07 PM >To: Rasesh Mody <rm...@marvell.com> >Cc: dev@dpdk.org; sta...@dpdk.org; Shahed Shaikh <shsha...@marvell.com> >Subject: Re: [EXT] [PATCH] net/qede: remove interrupt reconfigure in handler
>On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody <mailto:rm...@marvell.com> wrote: >>From: David Marchand <mailto:david.march...@redhat.com> >>Sent: Tuesday, June 25, 2019 6:39 AM >> >>---------------------------------------------------------------------- >>rte_intr_enable/rte_intr_disable configure the interrupt context on the >>kernel side (either uio or vfio). >>In VFIO case, calling it from the interrupt handlers triggers an unneeded >>interrupt handlers reconfiguration. >>During this reconfiguration window, the device can trigger interrupts which >>are left unserviced. >> >>Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824 >>Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") >>Fixes: 2ea6f76aff40 ("qede: add core driver") >>Cc: mailto:sta...@dpdk.org >> >>Signed-off-by: David Marchand <mailto:david.march...@redhat.com> >>--- >Change looks good, thanks. >Acked-by: Rasesh Mody <mailto:rm...@marvell.com> >Something still bothers me about the meaning of rte_intr_enable()... >Let me write a mail to a little more people :-) >For now, let's put this patch on hold. Another question I have is, is it required to re-enable interrupt by PMD at the end of interrupt handling by calling rte_intr_enable()? Does DPDK core / vfio/uio module take care of re-enabling the interrupt after the interrupt is handled? Thanks, Shahed
