On Sun, Jun 30, 2019 at 10:59:08AM +0300, Dekel Peled wrote: > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP > header. > - DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP > header. > > Original work by Xiaoyu Min. > > This patch introduces a new approach, using a simple integer instead > of using an action-specific structure for each of these actions. > This approach can be later applied to modify existing actions which > require only a single integer. > > Signed-off-by: Dekel Peled <dek...@mellanox.com> > Acked-by: Andrew Rybchenko <arybche...@solarflare.com>
You didn't take Andrew's comment [1] into account, this patch must be split. I'll highlight what needs to be moved to a pre-patch below. [1] https://mails.dpdk.org/archives/dev/2019-June/136101.html [...] > diff --git a/doc/guides/prog_guide/rte_flow.rst > b/doc/guides/prog_guide/rte_flow.rst > index a34d012..783a904 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1214,7 +1214,8 @@ Actions > ~~~~~~~ > > Each possible action is represented by a type. Some have associated > -configuration structures. Several actions combined in a list can be assigned > +configuration structures, some others use a simple integer. > +Several actions combined in a list can be assigned > to a flow rule and are performed in order. ^^^^ This must be moved to a separate patch ^^^^ BTW, how about "configuration structure" -> "configuration object" encompassing all kinds of objects once and for all instead? Such a generic term will be handy when actions start using floats or function pointers. [...] > /** > @@ -2140,7 +2172,7 @@ struct rte_flow_action_set_mac { > */ > struct rte_flow_action { > enum rte_flow_action_type type; /**< Action type. */ > - const void *conf; /**< Pointer to action configuration structure. */ > + const void *conf; /**< Pointer to action configuration. */ > }; ^^^^ This must be moved to a separate patch ^^^^ Same comment regarding "configuration object". -- Adrien Mazarguil 6WIND
