27/06/2019 19:23, Ferruh Yigit:
> On 6/10/2019 7:07 AM, Wei Zhao wrote:
> > There is no need to do such a check when set macsec for ixgbe, and
> > reconfig_device_queueand is also useless. If we do not delete this
> > unnessary code, users have to stop port before enable or disable
> > macsec, then restart this port after make configuration. All these
> > process are useless. As this cmdline is a private API which is only
> > used by ixgbe NIC, so remove it.
> >
> > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Wei Zhao <wei.zh...@intel.com>
> > Tested-by: Peng Yuan <yuan.p...@intel.com>
> > Acked-by: Bernard Iremonger <bernard.iremon...@intel.com>
>
> Applied to dpdk-next-net/master, thanks.
I disagree with the purpose of this patch.
It is removing some "generic" code with the argument that it is
not needed in the case of ixgbe, and ixgbe is the only user.
We may (and probably will) have other PMDs using this command,
so the argument is not OK.
I do not merge this patch in master for now.
Sorry for the inconvenience.
