make: Entering directory `/tmp/dpdk-tmp/examples/vhost'
  CC main.o
cc1: warnings being treated as errors
/tmp/dpdk-tmp/examples/vhost/main.c: In function ?new_device?:
/tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error:
    dereferencing pointer ?mbuf.486? does break strict-aliasing rules
/tmp/dpdk-tmp/examples/vhost/main.c:1503: note: initialized from here
...
/tmp/dpdk-tmp/examples/vhost/main.c:1503: note: initialized from here
/tmp/dpdk-tmp/x86_64-native-linuxapp-gcc/include/rte_ring.h:740: error:
    dereferencing pointer ?({anonymous})? does break strict-aliasing rules
/tmp/dpdk-tmp/examples/vhost/main.c:1804: note: initialized from here
make[1]: *** [main.o] Error 1

Fixes: d19533e8 ("examples/vhost: copy old vhost example")

Reported-by: Qian Xu <qian.q.xu at intel.com>
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
---
Changes in v4:
- Simplify patch, just casting to void *, without using new variables

Changes in v3:
- Remove even more unnecessary castings

Changes in v2:
- Remove unnecessary casting

 examples/vhost/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index dc3a012..f3c50c5 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -1500,7 +1500,7 @@ attach_rxmbuf_zcp(struct virtio_net *dev)
                }
        } while (unlikely(phys_addr == 0));

-       rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
+       rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
        if (unlikely(mbuf == NULL)) {
                LOG_DEBUG(VHOST_DATA,
                        "(%"PRIu64") in attach_rxmbuf_zcp: "
@@ -1801,7 +1801,7 @@ virtio_tx_route_zcp(struct virtio_net *dev, struct 
rte_mbuf *m,

        /* Allocate an mbuf and populate the structure. */
        vpool = &vpool_array[MAX_QUEUES + vmdq_rx_q];
-       rte_ring_sc_dequeue(vpool->ring, (void **)&mbuf);
+       rte_ring_sc_dequeue(vpool->ring, (void *)mbuf);
        if (unlikely(mbuf == NULL)) {
                struct vhost_virtqueue *vq = dev->virtqueue[VIRTIO_TXQ];
                RTE_LOG(ERR, VHOST_DATA,
-- 
2.5.0

Reply via email to