On 5/2/2019 4:44 PM, Herakliusz Lipiec wrote:
> add a warning message when user sets port config all rxq value larger
> than txq in interactive mode.
>
> Signed-off-by: Herakliusz Lipiec <herakliusz.lip...@intel.com>
Hi Hero,
Can you please give some context that why we need this check? What is broken
without this check?
Thanks,
ferruh
> ---
> app/test-pmd/cmdline.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 5a10c5f38..94be3c6f8 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1741,6 +1741,10 @@ cmd_config_rx_tx_parsed(void *parsed_result,
> }
> if (check_nb_rxq(res->value) != 0)
> return;
> + if (res->value > nb_txq) {
> + printf("Warning: rxq should not be larger than txq\n");
> + return;
> + }
> nb_rxq = res->value;
> }
> else if (!strcmp(res->name, "txq")) {
> @@ -1750,6 +1754,10 @@ cmd_config_rx_tx_parsed(void *parsed_result,
> }
> if (check_nb_txq(res->value) != 0)
> return;
> + if (res->value < nb_rxq) {
> + printf("Warning: rxq should not be larger than txq\n");
> + return;
> + }
> nb_txq = res->value;
> }
> else if (!strcmp(res->name, "rxd")) {
>
