24/06/2019 18:12, Honnappa Nagarahalli: > > > > + } else { > > > > + rte_panic("Invalid memory order\n"); > > > > > > > > > rte_panic should be removed from library. In this case, I think, > > > invalid mo can go for strongest barrier. > > It is added here to capture programming errors. > Memory order can be passed during compilation or during run time. > 'rte_panic' supports both of these. > Adding code with strongest memory order will mask the programming error.
An error must return a specific code from the function. rte_panic is really forbidden in libraries. We are in the process of removing all of them.