Thanks Maxime.

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Thursday, June 20, 2019 10:44 AM
> To: Zhang, Roy Fan <roy.fan.zh...@intel.com>; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [PATCH] examples/vhost_crypto: fix unchecked return value
> 
> 
> 
> On 5/15/19 6:25 PM, Fan Zhang wrote:
> > This patch tries to fix the coverity issue of unchecked return value.
> > Since the function that causes the problem is unused, it is removed
> > completely.
> >
> > Coverity issue: 336816
> > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com>
> > ---
> >   examples/vhost_crypto/main.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c
> > b/examples/vhost_crypto/main.c index ac7118e7e..cfb9dfda2 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
> >     .destroy_device = destroy_device,
> >   };
> >
> > -__attribute__((unused))
> > -static void clrscr(void)
> > -{
> > -   system("@cls||clear");
> > -}
> > -
> >   static int
> >   vhost_crypto_worker(void *arg)
> >   {
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
> 
> I'll change the title to:
> examples/vhost_crypto: remove unused function

Reply via email to